GitHub Notifications UX

[benibenj]

For the GitHub notifications we need an indication of a notification belonging to a PR in addition to the highlighted color.

Here are two examples for right aligned notification badges:

Another option is having the icon in the front (We currently also have the checkmark in the front to indicate the checked out PR):

[daviddossett]

Talked about this at the Redmond standup:

This version received positive feedback but there was some concern that it would look too similar to the git decorations.

This one maybe feels a bit noisier inlined but it could help clarify that it isn't related to git:

Also wanted to understand if I'm interpreting the idea correctly—would we show a dot on both the PR title and the actual file with the comment? And then both would clear when the last file with a unread notification was clicked?

FWIW this is using the circle-filled icon.

[benibenj]

Thanks for the feedback @daviddossett. The notification will only be indicated on the PR node and not on any files. Due to this I don't think it will be a big problem on the right, as there is no git indication on that node.

I believe we can't use the circle-filled icon in this case as it's a badge which only takes a string as input.

[daviddossett]

Oh ok, that simplifies things. Let's give that a try then!

[benibenj]

Close with #3839