vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Branch protection is shown as failed test

Open cbrnr opened this issue 1 year ago • 1 comments

  • Extension version: v0.46.1
  • VSCode Version: 1.69.2
  • OS: macOS

Steps to Reproduce:

  1. Open a PR in a repository with branch protection
  2. While tests are still running, branch protection is shown as a failed test
Screen Shot 2022-07-27 at 09 39 10

I think this is confusing, and because branch protection is already shown separately, it should not also show up as a failed test.

cbrnr avatar Jul 27 '22 07:07 cbrnr

I don't know about PRs within same repo - but this is definitely true for PRs from forks.

ssoworld avatar Sep 08 '22 13:09 ssoworld

We show it in the checks because branch protection could include an approving review, which is not otherwise shown (and the GitHub API doesn't appear to have a way to tell that it's an approving review that's missing, only that there's still something missing).

alexr00 avatar Dec 19 '22 16:12 alexr00

Tried to make it a little clearer by changing the wording and moving it to the end:

image

alexr00 avatar Dec 20 '22 15:12 alexr00

That's better I think, although it's the "X" status that's confusing. It looks like a failed test, and maybe it could be replaced with that slashed circle icon?

cbrnr avatar Dec 20 '22 15:12 cbrnr