Extension ignores github-enterprise.uri scheme and port

[idanga]

• Extension version: 0.40.0
• VSCode Version: 1.66.1 (Universal)
• OS: OS: Darwin arm64 21.4.0 (macOS 12.3.1)

Background

My company has a github enterprise behind a reverse proxy that requires client authentication (mTLS), which I believe is not yet supported (by Github, or by this extension). So to be able to connect, developers have a local reverse proxy (running on their dev machine) that handles the client authentication for them. This might look like http://local-github-proxy:9988, where local-github-proxy points to localhost. Notice the scheme is http (not https), and the non-standard port.

The extension tries to connect to the correct host (local-github-proxy), but over TLS and to port 443. Peeking at the code, this looks hard-coded (both the scheme and the port).

Steps to Reproduce:

1. Configure a github enterprise custom uri (the github-enterprise.uri setting) with a non-standard port and/or plain http scheme.
2. Configure an http/https server running on the custom port - doesn't have to be github enterprise, any server will do.
3. Try to connect using the extension, get network error (failed to connect).

[alexr00]

@idanga it looks like it might be pretty easy for me to support other ports. Is your host always localhost for the local reverse proxy? Are you able to use https instead of http for the local reverse proxy?

[alexr00]

Closing due to lack of activity.