vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Clarify GHE version compatibility

Open AntonioL opened this issue 2 years ago • 5 comments

I am getting this error here:

Creating comment failed: Error: GraphQL error: Field 'path' doesn't exist on type 'PullRequestReviewThread'
GraphQL error: Field 'isOutdated' doesn't exist on type 'PullRequestReviewThread'

I think we are using an old version of GHE. Can you clarify what is the minimum version of GHE compatible with the extension?

AntonioL avatar Mar 22 '22 19:03 AntonioL

Any update?

AntonioL avatar May 05 '22 20:05 AntonioL

According to this comment https://github.com/microsoft/vscode/pull/115940#issuecomment-854604614, maybe GHE versions released after 2020-09-23 or after 2.20.0 is the minimum ?

vohoanglong0107 avatar May 08 '22 15:05 vohoanglong0107

According to this comment microsoft/vscode#115940 (comment), maybe GHE versions released after 2020-09-23 or after 2.20.0 is the minimum ?

I can attest it is definitely not working in fully with an 2.22.0 installation.

AntonioL avatar May 13 '22 20:05 AntonioL

@alexr00 any updates, did you have a chance to give a look with the relevant teams?

AntonioL avatar May 18 '22 17:05 AntonioL

@AntonioL GitHub Enterprise support is completely community maintained, so I don't have any insight into this question. If that changes and I start maintaining the Enterprise support too I will re-visit all Enterprise issues.

alexr00 avatar May 30 '22 15:05 alexr00

I'm revisiting all GitHub Enterprise issues. I've tested all currently supported minor versions of GitHub Enterprise with the extension. I've made some fixes and in the next release we plan to announce that the extension works with GitHub Enterprise starting with GitHub Enterprise version 3.2.

@AntonioL are you still on version 2.2?

alexr00 avatar Sep 20 '22 13:09 alexr00

I've updated the wiki to indicate the supported versions: https://github.com/microsoft/vscode-pull-request-github/wiki#version-051-and-moving-forward

alexr00 avatar Sep 21 '22 14:09 alexr00