vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard
verified publisher icon microsoft

No comments in the editor when visiting file changes from commits

Open rebornix opened this issue 7 years ago • 3 comments

  • VSCode version: 1aab8e140e17f30a60b95df32264a39eb155765d
  • Extension version: 0.0.7

Reproduce steps:

  • Checkout Pull Request from the tree view https://github.com/Microsoft/vscode-pull-request-github/pull/94
  • Expand Commits node from Changes In Pull Request section
  • Expand Commit "Tweak the authentication user messages"
  • One file change src/github/credentials is shown and it has a comment icon
  • Click the file change, a diff editor is opened. No comment is shown in the editor

rebornix avatar Aug 08 '18 04:08 rebornix

A DocumentCommentsProvider should be registered when visiting commits which have comments.

rebornix avatar Aug 08 '18 04:08 rebornix

As there is no comments, we don't see commenting range decorations as well.

rebornix avatar Aug 08 '18 18:08 rebornix

Viewing comments works, but adding them still does not.

alexr00 avatar Dec 18 '23 16:12 alexr00