Commits list in "Changes in pull request" tree only shows first 30 commits

[IllusionMH]

Issue Type: Bug

Looks similar to #375 but for commits list.

If PR has more than 30 commits (example) only first 30 are shown and there is no "Load more" button

Extension version: 2019.7.36902 VS Code version: Code - Insiders 1.37.0-insider (92da68a71cfb60bd3b9b0d7fbfb2a7e1fff9dbaf, 2019-08-01T05:37:54.848Z) OS version: Windows_NT x64 10.0.18362

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software oop_rasterization: disabled_off protected_video_decode: enabled rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.72GB (17.67GB free)
Process Argv
Screen Reader	no
VM	0%

[IllusionMH]

At first I thought that it can be fixed just using approach from commit https://github.com/microsoft/vscode-pull-request-github/commit/cd5f1dd04e90655409765ee973ac4db611392431 in getPullRequestCommits function.

However, on second thought it looks like this function will always return list of commits from PR on GitHub, but if local repo doesn't have all commits from PR that there is chance to trigger diff view on commit that isn't available locally. Do I understand correctly that proper solution will be using local git API to get all available commits in PR?

[haringsrob]

I found this today, opened a big pr, and indeed only a subset of the commits were visible.

I was checking settings but could not find anything related, refreshed, restarted all without any effect.

@rebornix: While this could be a feature request it seems more that this is a bug?

[costas90]

Is there a solution to this?

[alexr00]

To verify:

1. Install the pre-release version of the extension
2. Make a PR with > 30 commits
3. Check out the PR with the extension if you haven't already
4. In the "Changes in Pull Request" view, there's a "Commits" node. Expand that.
5. Verify that you have all of your commits listed there.