vscode-lombok icon indicating copy to clipboard operation
vscode-lombok copied to clipboard

user setting will force overwrite after install

Open foxundermoon opened this issue 5 years ago • 7 comments

before installing the extension, there is many customs configuration.

but now all old configuration lost, and it is the new configuration.

{
  "java.jdt.ls.vmargs": "-noverify -Xmx1G -XX:+UseG1GC -XX:+UseStringDeduplication -javaagent:\"/Users/fox/.vscode/extensions/gabrielbb.vscode-lombok-0.9.7/server/lombok.jar\" -Xbootclasspath/a:\"/Users/fox/.vscode/extensions/gabrielbb.vscode-lombok-0.9.7/server/lombok.jar\""
}

foxundermoon avatar Mar 06 '19 09:03 foxundermoon

do not edit user setting file by the programming.

foxundermoon avatar Mar 06 '19 09:03 foxundermoon

Thanks for reporting it. I will check it out

GabrielBB avatar May 04 '19 04:05 GabrielBB

this also causes problems for users using VSCode Remote Development support (https://code.visualstudio.com/docs/remote/remote-overview) - if vscode-lombok is installed outside of a devcontainer or inside of one, any containers without lombok support installed will fail to start java language server due to the above config.

jrussellsmyth avatar Jan 28 '20 00:01 jrussellsmyth

@jrussellsmyth I don’t have experience using Remote Development in VSCode. Do you know why it fails? I assume it is because the container can’t resolve the jar path that is being appended to the config, right?

GabrielBB avatar Jan 28 '20 00:01 GabrielBB

@GabrielBB that is correct, you are adding that config at a global level, and any config that does not include your plugin does not have that jar in the location you expect it.

The reason or using remote development for most is to use isolated Docker containers as development environment to isolate each projects configuration. but because your plugin puts this config in the global space, it is active even when the filesystem is different.

This even happens to the main non-remote project if you add the plugin in a remote project, again, as the config change is at the global level.

jrussellsmyth avatar Jan 28 '20 17:01 jrussellsmyth

@GabrielBB I'm also encountering the same issue with java server not being able to find the lombok jar inside the dev container. I don't even use lombok on this specific project but the extension is causing the java server to crash.

joel-jeremy avatar May 14 '21 08:05 joel-jeremy

I'm also running into this issue when using devcontainers. The correct path inside a dev container is: /home/vscode/.vscode-server/extensions/gabrielbb.vscode-lombok-1.0.1/server/lombok.jar

0xVesion avatar Sep 23 '21 12:09 0xVesion