vscode-jupyter icon indicating copy to clipboard operation
vscode-jupyter copied to clipboard

Create meta context keys for notebook keybinding enablement

Open joyceerhl opened this issue 3 years ago • 2 comments

The when clauses for notebook editor keybindings are getting too long to easily parse. Per @IanMatthewHuff we should create our own meta context keys so we can express the conditions as follows:

"when": "jupyterNotebookCellEditorSelected || jupyterCellListCodeSelected"

joyceerhl avatar Jun 15 '21 20:06 joyceerhl

Not sure how we can do that. As you toggle between notebooks, we'll need to update our context keys and that's async. i.e the context keys will change only after a few seconds, hence the commands/icons will unnecessarily appear & then disappear or viceversa. I dont think we can create wrappers around vscode context keys

DonJayamanne avatar Jul 07 '21 19:07 DonJayamanne

I believe Joyce was referring to making context keys that are combinations of others so our when clauses are simpler.

rchiodo avatar Oct 18 '21 22:10 rchiodo

Chatted about this at standup and currently not an easy way to do this, and no current issues with this, so closing.

IanMatthewHuff avatar Nov 04 '22 21:11 IanMatthewHuff