vscode-jupyter icon indicating copy to clipboard operation
vscode-jupyter copied to clipboard

Make Interactive Windown Output Like the Visual Debugger Tab

Open AeneasZhu opened this issue 6 years ago • 14 comments

image

Will be doable if the output cell shown inside the pop-up tab like the visual debugger tab? Making interactive output inside pop-up tab like the visual debugger tab wouldn't be very difficult as it's been achieved by the visual debugger, is it? Another feature is that when the cursor move outside the cell the pop-up tab will disappear and show another cell's output where the cursor is.

I know vscode python team is currently working on improving the New Notebook, but it won't be compatible with 3rd-party extentions soon. Thus, I think what I suggest above is another better way to improve the experience of data science coding of VsCode and much more doable than making Notebook compatible with 3rd-party extentions.

Would that be possible? @rchiodo

AeneasZhu avatar Dec 04 '19 02:12 AeneasZhu

I believe we already have this suggestion on our backlog: https://github.com/microsoft/vscode-python/issues/6368

And yes it is technically feasible, just not sure we'll get to it any time soon. Please upvote the other issue. Thanks.

rchiodo avatar Dec 04 '19 16:12 rchiodo

Reopening. I misunderstood @AeneasZhu's suggestion. This is actually a suggestion to instead of (or in addition to) the interactive window, we could also show outputs in a popup window. So an on hover provider that expands outputs for a cell when hovering over it I believe.

rchiodo avatar Dec 05 '19 00:12 rchiodo

Reopening. I misunderstood @AeneasZhu's suggestion. This is actually a suggestion to instead of (or in addition to) the interactive window, we could also show outputs in a popup window. So an on hover provider that expands outputs for a cell when hovering over it I believe.

Thanks very much. And what about this feature's feasibility? And https://github.com/microsoft/vscode-python/issues/6368 . I don't think it might be very difficult since it's been achieved in visual debugger, is it?

AeneasZhu avatar Dec 05 '19 00:12 AeneasZhu

I don't think this would be impossible as I think the hover provider API allows returning HTML. https://code.visualstudio.com/api/references/vscode-api#Hover

Not sure what we'd hover over though? The cell header? The last line?

rchiodo avatar Dec 05 '19 00:12 rchiodo

I don't think this would be impossible as I think the hover provider API allows returning HTML. https://code.visualstudio.com/api/references/vscode-api#Hover

Not sure what we'd hover over though? The cell header? The last line?

Then, they will be on your TODO List, won't they? And be classed as Epic?

AeneasZhu avatar Dec 05 '19 00:12 AeneasZhu

Sorry but our todo list is decided based on a number of factors, one of which is how many people are requesting something. A single up vote usually doesn't meet the requirements for being implemented any time soon.

rchiodo avatar Dec 05 '19 00:12 rchiodo

Sorry but our todo list is decided based on a number of factors, one of which is how many people are requesting something. A single up vote usually doesn't meet the requirements for being implemented any time soon.

Is still there any other possibility? I can't call others to upvote this.

AeneasZhu avatar Dec 05 '19 00:12 AeneasZhu

You can submit a PR with the change required to make this possible. Or somebody else could as well.

rchiodo avatar Dec 05 '19 00:12 rchiodo

You can submit a PR with the change required to make this possible. Or somebody else could as well.

But how to submit ? Could you submit ?

AeneasZhu avatar Dec 05 '19 00:12 AeneasZhu

You follow the guidelines here for contributing: https://github.com/microsoft/vscode-python/blob/master/CONTRIBUTING.md

rchiodo avatar Dec 05 '19 01:12 rchiodo

Let me also say that if you go down this path, we may not even accept the changes. Especially UI changes. So you might end up with your own private branch as the only source of this change.

rchiodo avatar Dec 05 '19 01:12 rchiodo

You follow the guidelines here for contributing: https://github.com/microsoft/vscode-python/blob/master/CONTRIBUTING.md

Sorry, it seems too complicated for me to contribute that. Could you submit this suggestion to your team or PM?

AeneasZhu avatar Dec 05 '19 02:12 AeneasZhu

Hi @AeneasZhu, we have been mulling over additional changes to the debugging experience for the interactive window and this suggestion is on our radar again. However, I'd like some clarification. In your suggestion, are you specifically talking mainly text based output to appear in the popup window when you hover? In other words, if you hover over a variable that contains a float you see the actual value of that variable. If you hover over a pandas dataframe you see the rows and columns of data in the df?
OR Are you also wanting to see other visualizations such as plots when you hover over a "figure" variable from plotly or matplotlib?

I believe you're mainly talking about just text based output. Please let us know.

greazer avatar Jun 29 '20 17:06 greazer

@greazer

Sorry to reply your comment late. Acutually, this suggestion was not about interactive window debugger. What I suggested before is to make the result of cell that have been run shown on a popup like the hydrogen on Atom, since Vim Extension is not available on Notebook so far.

AeneasZhu avatar Jul 05 '20 01:07 AeneasZhu

closing with low vote count

amunger avatar Dec 06 '22 17:12 amunger