vscode-jupyter icon indicating copy to clipboard operation
vscode-jupyter copied to clipboard

Not Automatically picking java kernel when opening a Java Notebook

Open amunger opened this issue 3 years ago • 6 comments

Seems like it's failing pretty often (if not always) in raw, conda, 3.9, ubuntu-latest setup

amunger avatar Jul 21 '22 21:07 amunger

screenshot confirms wrong kernel was selected image

amunger avatar Jul 22 '22 16:07 amunger

Still failing after the regression fix, I'm pretty sure CI machines do not have the kernel installed required for this test

amunger avatar Jul 25 '22 22:07 amunger

This isn't a flaky tet issue, the code is broken, we're not listing all of the kernels correctly.

DonJayamanne avatar Aug 08 '22 21:08 DonJayamanne

@IanMatthewHuff I tried to enable this test and found that the code was actually buggy, attempted fix is here https://github.com/microsoft/vscode-jupyter/pull/11053

Basically today we can run into situations where the kernels on disc are not shown. The problem is with the new code (changes as a result of) written to display the new kernel picker ux. Basically we have code that will fetch the controllers, and then subsequently we attempt to run the same method again and this sime the previous request is cancelled and that causes issues.

On a side note, the PR ensures that none of the cancellation tokens are nullable, if you follow the code path its impossible for them to be null, i.e. they are always valid.

DonJayamanne avatar Aug 11 '22 17:08 DonJayamanne

Probably blocked on https://github.com/microsoft/vscode-jupyter/issues/11153 I say that because its possible that changes in #11153 would end up fixing this issue.

DonJayamanne avatar Sep 07 '22 22:09 DonJayamanne

Adding my self, as I believe the problem is in the kernel finder (my area) and not necessarily in the code that matches kernels.

DonJayamanne avatar Sep 07 '22 22:09 DonJayamanne

Should now be fixed

DonJayamanne avatar Nov 14 '22 17:11 DonJayamanne

Note: This was an actual bug that users were running into and cause users not to see their kernels (including virtual envioronments)

DonJayamanne avatar Nov 14 '22 17:11 DonJayamanne