vscode-java-dependency icon indicating copy to clipboard operation
vscode-java-dependency copied to clipboard

Rebuild commands mostly perform "full" instead of "incremental"

Open rgrunber opened this issue 8 months ago • 0 comments

Looking through the UI contributions, I see that builds tend to run "full".

https://github.com/microsoft/vscode-java-dependency/blob/84af4b35654fe0167b0bff1d39cd0ccc3d4b07c6/package.json#L612-L616

https://github.com/microsoft/vscode-java-dependency/blob/84af4b35654fe0167b0bff1d39cd0ccc3d4b07c6/package.json#L704-L708

https://github.com/microsoft/vscode-java-dependency/blob/84af4b35654fe0167b0bff1d39cd0ccc3d4b07c6/src/views/dependencyDataProvider.ts#L57-L58

https://github.com/microsoft/vscode-java-dependency/blob/84af4b35654fe0167b0bff1d39cd0ccc3d4b07c6/src/views/dependencyDataProvider.ts#L73-L80

From https://github.com/microsoft/vscode-java-dependency/issues/854#issuecomment-2323836295 & https://wiki.eclipse.org/FAQ_How_do_I_turn_off_autobuilding_of_Java_code%3F the consensus seems to be that if a user has a large enough project, and they observe very slow performance on builds, one thing to try is disabling autobuild and switching to manually performing the build. If doing this, wouldn't it be best to make every build-related UI element do it incrementally ? That way the least amount of work is done, and if a full build is needed, the incremental builder would just fall back to that.

@jdneo , what are your thoughts on a proposal to change most of these commands to "incremental" ? Are there certain UI elements that should absolutely remain "full" ?

Update:

  • Eclipse IDE's Build All is incremental by default : https://github.com/eclipse-platform/eclipse.platform.ui/blob/70a35a94b2c6aa67018f919d627b4426c17cb8a4/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/handlers/BuildAllProjectsHandler.java#L37
  • JDT's Build Project is incremental by default : https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/3d780e85b18b6bd8f7548efdc37367959b1218e8/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/BuildActionGroup.java#L129

rgrunber avatar Apr 25 '25 19:04 rgrunber