vscode-edge-devtools icon indicating copy to clipboard operation
vscode-edge-devtools copied to clipboard

Consider changing your activation events

Open Tyriar opened this issue 3 years ago • 1 comments

Hi from the VS Code core team 👋

I noticed you have a lot of very eager activation events:

https://github.com/microsoft/vscode-edge-devtools/blob/7bc1699ca9a98bcda09ba954df2658fa543a0909/package.json#L39-L57

Ideally extensions would only activate when they are actually being used (ie. to debug Edge). Here are some thoughts:

  • Use onDebugInitialConfigurations and onDebugResolve instead of onDebug (docs recommends this). I rarely debug using this extension but often debug, so the Edge extension ends up activating and wasting system resources.
  • Avoid onLanguage unless you have a compelling reason to do so, opening a typescript file does not imply I want to debug it via Edge.

Tyriar avatar Jan 18 '22 14:01 Tyriar

Thanks for this, we will look into it.

codepo8 avatar Jan 18 '22 19:01 codepo8