vscode-edge-devtools icon indicating copy to clipboard operation
vscode-edge-devtools copied to clipboard

Use substituted config instead of raw

Open shanto opened this issue 1 year ago • 2 comments

See this link for details. https://code.visualstudio.com/api/references/vscode-api#DebugConfigurationProvider → resolveDebugConfigurationWithSubstitutedVariables

This commit fixes the issue that variables in debug configs are not resolved, and instead passed as-is to msedge.exe. Using the proper VS Code API easily solves it.

Before

master

After

fix-subst

shanto avatar Oct 10 '24 22:10 shanto

How to test?

Create a debug config as below and try to launch it.

{
			"name": "EdgeBrowserInternal",
			"userDataDir": "${workspaceFolder}/.vscode/edge",
			"type": "vscode-edge-devtools.debug",
			"request": "launch",
}

Without the fix, msedge.exe will complain about non-existing user profile directory. With the fix, Microsoft Edge will launch with the customized user data directory as expected.

shanto avatar Oct 10 '24 22:10 shanto

@vidorteg please respond

shanto avatar Oct 21 '24 12:10 shanto

Contact Us

salvatores-art avatar Nov 08 '24 20:11 salvatores-art

Hi @shanto,

Thank you for the contribution, I'll take a look and reply back.

vidorteg avatar Nov 08 '24 22:11 vidorteg