vscode-edge-devtools icon indicating copy to clipboard operation
vscode-edge-devtools copied to clipboard

cdpTarget is using a getter to override a base class property

Open vidorteg opened this issue 5 years ago • 0 comments

Issue:

cdpTarget is using a getter to override a base class property (description and tooltip), it is also using the getter to do some lazy init on the value. This was marked as a warning in typescript 3.8 , but it was recently marked as an error on typescript 4 as it is a bad practice. Should not block the upgrade to typescript 4 as (as mentioned) is not an error per se is a bad practice that should be refactored.

vidorteg avatar Sep 02 '20 21:09 vidorteg