vscode-edge-devtools icon indicating copy to clipboard operation
vscode-edge-devtools copied to clipboard

Setting moduleResolution to bundler causes red squiggles

Open neilenns opened this issue 1 year ago • 10 comments

Environment (please complete the following information):

  • OS (e.g., Windows 10): Windows 11
  • Extension version (e.g., 1.2.3): v2.1.2

Describe the bug:

The extension causes red squiggles when moduleResolution is set to bundler in tsconfig.json.

Repro steps:

  1. Create a new React Typescript project using Vite: npm create vite@latest my-react-app --template react-ts
  2. Open the generated tsconfig.json

Expected behavior:

No red squiggles. bundler is a valid module resolution type as of Typescript 5.

Additional context:

Disabling the extension makes the red squiggles go away.

neilenns avatar Jul 10 '23 17:07 neilenns

Thanks for filing this. Tracking this on the team's backlog.

captainbrosset avatar Jul 11 '23 09:07 captainbrosset

When will this be fixed? Been bugging for months.

CrossScarDev avatar Sep 17 '23 23:09 CrossScarDev

Apologies for this. Unfortunately, we have no timeline to share for this specific issue.

captainbrosset avatar Sep 18 '23 07:09 captainbrosset

I think this has something to do with Webhint.

Disabling vscode-edge-devtools: Webhint works for me.

bmc1995 avatar Nov 09 '23 00:11 bmc1995

I think this has something to do with Webhint.

Disabling vscode-edge-devtools: Webhint works for me.

No don't do this it is built in edge.

mpotane avatar Nov 10 '23 23:11 mpotane

This issue may seem small but I legitimately considered uninstalling Edge Tools entirely over it. How hard can it be to Add 'Bundler' to a list of valid options?!

John-Dennehy avatar Nov 15 '23 11:11 John-Dennehy

Same

This issue may seem small but I legitimately considered uninstalling Edge Tools entirely over it. How hard can it be to Add 'Bundler' to a list of valid options?!

I use Edge quite some time due to the marketing and effort to make it as better tool for end user than just a browser. I just have this ext recommended and tried in a basic new web project that I working on.

I'm not sure how helpful this ext is, it can't relate with .tsx file anyway, but this ext "helps" me by giving this error from outdated ts config check. Webhint project doesn't seems active and the ts config schema latest update was last year.

References: webhintio/hint/blob/main/packages/parser-typescript-config/src/schema.json webhintio/hint/issues/5719

CallMeLaNN avatar Dec 01 '23 15:12 CallMeLaNN

Firstly, thanks for putting option to disable the webhint in VS Code settings. You can disable it to get rid of the errors. image

Secondly, I'm wondering why an outdated linter is enabled by default in the extension, or why it's included at all. Many of us already use our own linters with settings that we prefer for our projects. It's annoying to have an extra one pop up from a debugging extension.

I think it would be better to remove webhint, or at least have the extension check if there's already a linter set up in the workspace. This way, new developers can still be introduced to the concept, which I assume why it is included in the first place.

oddiz avatar Dec 18 '23 11:12 oddiz

still a issue in 2023. Its a bit confusing why this extension's linting would precedence over project linting rules in tsconfg.

ShravanSunder avatar Feb 07 '24 13:02 ShravanSunder

Thanks for reporting this. We're working on updating webhint with a fix. In the mean time as a workaround, you can disable a specific rule by using a .hintrc file without disabling webhint altogether.

You can check the documentation on hintrc file here: Hints | webhint documentation and you can read about the specific rules that need to be disabled in here: Valid TypeScript configuration | webhint documentation

ElormCoch avatar Feb 27 '24 20:02 ElormCoch