vscode-edge-devtools icon indicating copy to clipboard operation
vscode-edge-devtools copied to clipboard

Launch Project silently fails with faulty vscode-edge-devtools.defaultUrl setting

Open henrikvilhelmberglund opened this issue 3 years ago • 1 comments

Environment (please complete the following information):

  • OS (e.g., Windows 10):
  • Extension version (e.g., 1.2.3):

Win10 v2.1.1

Describe the bug:

Launch Project silently fails with faulty vscode-edge-devtools.defaultUrl setting. After generating a launch.json in a new folder I ended up with "url": "127.0.0.1:5500", instead of "url": "http://127.0.0.1:5500", because I had mistakenly typed 127.0.0.1:5500 in the default URL field in settings instead of http://127.0.0.1:5500.

This caused Edge Devtools to not open at all when running Launch Project which made me a bit confused until I found out the problem.

I'm not sure what the best solution is but maybe giving an error saying the headless browser couldn't launch because of a faulty URL or maybe just prepending http:// in the URL if http:// seems to be missing.

Repro steps:

  1. In settings set the default URL to 127.0.0.1:5500
  2. In a new project add an index.html with some boilerplate code.
  3. Press Launch Project.
  4. The debugging toolbar appears but Edge Devtools doesn't open to the side and there's an error that it couldn't connect to the instance.

Expected behavior:

  1. Give an error that Edge Devtools couldn't open because of a faulty URL setting or
  2. Prepend http:// to 127.0.0.1:5500 so that it magically works anyway.

Additional context:

henrikvilhelmberglund avatar Oct 16 '22 11:10 henrikvilhelmberglund

Thanks for this, sounds like the 404 page that I proposed #1219 should fix that issue. I also like the idea of trying to prepend http://.

codepo8 avatar Oct 18 '22 15:10 codepo8

tracked, thank you

codepo8 avatar Dec 12 '22 16:12 codepo8