vscode-edge-devtools icon indicating copy to clipboard operation
vscode-edge-devtools copied to clipboard

Running the command vscode-edge-devtools-view.close-instance does not close the instance

Open frigvid opened this issue 3 years ago • 0 comments

Environment (please complete the following information):

  • OS: Microsoft Windows 10 Pro v2009 (Win32NT 10.0.19044.0)
  • Machine: Surface Pro 3
  • Extension version: 2.1.1

Describe the bug:

When launching a debugging session with default settings (e.g. no launch.json) using the Launch Edge Headless and attach DevTools (workspace) or any other preset, the command vscode-edge-devtools-view.close-instance in Ctrl + Shift + P, does not close the instance. You can close it normally using either the Edge DevTools sidebar or the floating debug menu.

Unless I've misunderstood something, I'd think vscode-edge-devtools-view.close-instance should do the same as the close instance buttons. If this is not intended behavior, I think this would be a nice feature request for use with Visual Studio Code Tasks and Launch configurations. Though issue #846 needs to be fixed for that to be useful.

Repro steps:

  1. Start a debugging session using a default preset like Launch Edge Headless and attach DevTools (workspace)
  2. Open the command launcher with Ctrl + Shift + P
  3. Run the command vscode-edge-devtools-view.close-instance or Microsoft Edge Tools: Close Instance

Expected behavior:

  1. Start a debugging session using a default preset like Launch Edge Headless and attach DevTools (workspace)
  2. Open the command launcher with Ctrl + Shift + P
  3. Run the command vscode-edge-devtools-view.close-instance or Microsoft Edge Tools: Close Instance
  4. The session ends and the Edge DevTools closes like when you end the session through the Edge DevTools sidebar or floating menu.

frigvid avatar Sep 15 '22 20:09 frigvid