vscode-docker icon indicating copy to clipboard operation
vscode-docker copied to clipboard

Don't communicate with docker until necessary

Open guilhem opened this issue 2 years ago • 3 comments

Currently, docker plugin communicate with docker at each run, even if not necessary. When using socket activation, it spawns docker daemon + all networks, and it has impact on battery consumption.

Postponing docker communication will prevent it.

Another way can be to separate Dockerfile linting plugin from Docker management, itself. User being able to disable Docker communication without losing linting.

guilhem avatar Mar 25 '22 14:03 guilhem

This would probably be solved by #3263. Right now our initial communications with Docker are to get the context so we can set up Dockerode; if the CLI alone was used then none of that would be needed, and I think all features could become truly demand-based.

bwateratmsft avatar Mar 25 '22 14:03 bwateratmsft

I added this issue to the list on #3263.

bwateratmsft avatar Mar 25 '22 14:03 bwateratmsft

thanks @bwateratmsft, I subscribed.

guilhem avatar Mar 25 '22 14:03 guilhem

Fixed by #3586

bwateratmsft avatar Oct 21 '22 19:10 bwateratmsft

This has now been released in Docker extension version 1.23.0.

bwateratmsft avatar Nov 28 '22 19:11 bwateratmsft