vscode-docker icon indicating copy to clipboard operation
vscode-docker copied to clipboard

Show more Info in Network Panel

Open JM-Lemmi opened this issue 3 years ago • 5 comments

It would be nice, if the network panel could show more information with a dropdown.

The most useful information in my opinion would be a list of containers connected to the network (and their IP addresses). You can currently get this info from the Inspect-option, but having this info at a glance would be nice.

Mockup: github-vscodedocker-netpanel-mockup

JM-Lemmi avatar Nov 30 '21 12:11 JM-Lemmi

It's not as detailed but the tooltip will show containers: image

bwateratmsft avatar Nov 30 '21 14:11 bwateratmsft

@JM-Lemmi I can't believe I didn't think of this before, but you can set the grouping for the Containers view to use networks. It gives the view you're showing, but in the Containers window instead.

  1. Click the gear icon on the Containers view image
  2. Choose Group By, and select Networks image

Containers will be shown grouped by network: image

I'm going to leave this issue open since there's not currently a way to have the IP address shown in the description like in the mockup, but this may still be helpful.

bwateratmsft avatar Jan 27 '22 15:01 bwateratmsft

Personally I'd also like to be able to see the containers more easily in the networks view. If we could agree on a design I'd be happy to open a PR with an implementation.

The main thing I am not sure about is if the containers as seen in the networks view should be the same as the ones shown in the container view - for example should you be able to right-click and do everything you can normally do with them?

I'd want to be able to right-click a container to disconnect it.

stuartthomson avatar Apr 04 '22 15:04 stuartthomson

That would be awesome. I don't feel comfortable enough with TS to be opening a PR, but I'd happily assist you if I can.

I think the standard options should definitely be there. Attach, Logs, Stop, Restart.

Disconnect on the container menu and connect on the network menu would be obvious choices for extra options. Maybe drag and drop between networks? Depending on how hard that would be to implement.

JM-Lemmi avatar Apr 04 '22 22:04 JM-Lemmi

The biggest problem is that a container can be connected to multiple networks. Our tree view framework would not work, as the same container node would need to show up as a child of multiple network nodes. Altering the framework to support this scenario would be possible, but quite costly.

The container view sort of cheats on this when grouping by network, as it treats networks as a single concatenated string--but I don't think that approach would really work for the networks view.

bwateratmsft avatar Apr 05 '22 16:04 bwateratmsft