vscode-docker icon indicating copy to clipboard operation
vscode-docker copied to clipboard

An error dialog pops up after running 'Copy Image Digest' for one running task run

Open v-xuanzh opened this issue 6 years ago • 2 comments

OS: All Build Version: 20190731.7

Steps to reproduce:

  1. Command palette -> Docker Images: Run Azure CLI
  2. Run these commands in the new terminal to set environment variables:
  • ACR_NAME=registry-name
  • GIT_USER=github-username
  • GIT_PAT=personal-access-token
  • az login
  • az account set -s your-subscription-name
  • az acr task create --registry $ACR_NAME --name taskhelloworld --image helloworld:{{.Run.ID}} --context https://github.com/$GIT_USER/acr-build-helloworld-node.git --branch master --file Dockerfile --git-access-token $GIT_PAT
  1. Expand the build task named 'taskhelloworld' from the REGISTRIES window
  2. Try to execute 'Run Task'.
  3. Right click the running task run then click 'Copy Image Digest'.

Expect Experience:

There is no error and the image digest can be copied successfully.

Actual Experience:

An error dialog pops up. image

v-xuanzh avatar Aug 01 '19 10:08 v-xuanzh

Verified on the latest build 20200714.2, this issue still reproduces for now. I will continue to track this issue.

v-mengwe avatar Jul 15 '20 07:07 v-mengwe

This occurs because the task is still running, so an output image hasn't been obtained yet. We can add code to hide the "Copy image digest" command for incomplete task runs, similar to how we hide other commands depending container/image/etc. state.

bwateratmsft avatar Jul 15 '20 14:07 bwateratmsft

Closing as we've removed support for ACR tasks.

bwateratmsft avatar Nov 07 '23 16:11 bwateratmsft