vscode-dev-containers icon indicating copy to clipboard operation
vscode-dev-containers copied to clipboard

Added folder for kubernetes helm with docker compose. Include docker-…

Open amura opened this issue 5 years ago • 5 comments

I have created this PR to include a docker-compose configuration for when running Kubernetes and Helm inside docker. This will make it easier for those who are not only using a dockerfile configuration as all the mounts are now done inside the docker-compose. I have also included a post create command that runs the existing test file so it demonstrates successful configuration at the end.

amura avatar Apr 15 '20 04:04 amura

CLA assistant check
All CLA requirements met.

msftclas avatar Apr 15 '20 04:04 msftclas

Thanks for the contribution! A couple of things that would be great if you could do:

  1. The way this repository works is that all the contents for the dev container should be in the .devcontainer folder. This appears to depend on docker-compose.yml a level up which the person using the definition may already have on disk and we wouldn't want to overwrite.
  2. Could you link to the best way to contact you from the README.md under contributor in case there are questions for you?

Chuxel avatar Apr 21 '20 00:04 Chuxel

@Chuxel thanks for reviewing this. I have made the updates as you suggested!

amura avatar May 01 '20 12:05 amura

Accidental close

amura avatar Mar 03 '22 15:03 amura

Thanks again for opening this and for the discussion so far.

As a heads up, our team has been actively focused on an updated plan for community contributions and this repo moving forward, which we've now outlined in this issue: https://github.com/microsoft/vscode-dev-containers/issues/1589. This includes moving to a couple new repos for images (https://github.com/devcontainers/images) and Features (https://github.com/devcontainers/features).

We anticipate to have a similar repo and distribution process for templates/definitions. We'll keep everyone updated (likely via another issue in this repo or comment on https://github.com/microsoft/vscode-dev-containers/issues/1589) when our new templates repo is available and the process is defined.

Please let me know if you have any questions, thank you!

bamurtaugh avatar Sep 02 '22 21:09 bamurtaugh