vscode-dev-containers icon indicating copy to clipboard operation
vscode-dev-containers copied to clipboard

Use stronger wording in docker-compose template

Open sliekens opened this issue 3 years ago • 1 comments

I was playing with different mount options for my workspace and found that "workspaceFolder" is not optional. The comment vaguely suggests that you can set this to something other than a volume mount, but that only confused me further.

sliekens avatar Jun 01 '22 13:06 sliekens

@chrmarti do you have thoughts on this one?

bamurtaugh avatar Jun 03 '22 21:06 bamurtaugh

Thanks again for opening!

As a heads up, our team has been actively focused on an updated plan for community contributions and this repo moving forward, which we've now outlined in this issue: https://github.com/microsoft/vscode-dev-containers/issues/1589. This includes moving to a couple new repos for images (https://github.com/devcontainers/images) and Features (https://github.com/devcontainers/features).

We anticipate to have a similar repo and distribution process for templates/definitions. We'll keep everyone updated (likely via another issue in this repo or comment on https://github.com/microsoft/vscode-dev-containers/issues/1589) when our new templates repo is available and the process is defined.

Please let me know if you have any questions, thank you!

bamurtaugh avatar Sep 02 '22 21:09 bamurtaugh

A little late, but the change looks good. (workspaceFolder is required for Docker Compose and it is fair to say that usually this corresponds to a mount point.)

chrmarti avatar Sep 09 '22 13:09 chrmarti

Thanks @chrmarti - I'll merge this change in.

bamurtaugh avatar Sep 09 '22 16:09 bamurtaugh