base.Dockerfile included in built package

[chrmarti]

Not sure when this started, but with 0.237.0 I see the base.Dockerfile included in the package we use for Remote-Containers. E.g., with the Node.js & TypeScript template.

[joshspicer]

Interesting, I am unsure what could've changed 🤔

[Chuxel]

It looks like pagination logic got thrown off somehow. See the log snippet below from the package step in the release. There are two pages despite the fact only one is configured. I suspect this was triggered by this PR that removed the parent from java-8 since it's no longer needed. That exposed an existing bug.

@joshspicer If you tactically add the parent back, that should resolve it since that only affects build order. You can then see what might be throwing the logic off.

(*) Builds paginated as follows: [
    [
        "debian",
        "ubuntu",
        "cpp",
        "alpine",
        "codespaces-linux",
        "dotnet",
        "go",
        "java",
        "java-8",
        "php",
        "python-3",
        "python-3-anaconda",
        "python-3-miniconda",
        "rust",
        "ruby",
        "jekyll"
    ],
    [
        "javascript-node",
        "typescript-node",
        "github.com/microsoft/vscode"
    ]
]
(*) Processing page 1 of 1.

The definitions listed in page 1 have their base.Dockerfile removed, but page 2 does not.

[chrmarti]

Are we still using npm for creating the package? We could just add base.Dockerfile to the .npmignore.

[joshspicer]

@samruddhikhandale , as you're directly working with the build tool, something to keep an eye out for.

[chrmarti]

Opened #1494 for the .npmignore suggestion. We need to get a fix in place for the release.

[chrmarti]

Still an issue in 0.241.1. 🤔