clang-diagnostic strings appear as warnings for C_Cpp.codeAnalysis.clangTidy.checks

[sean-mcmanus]

Repro is

    "C_Cpp.codeAnalysis.clangTidy.checks.disabled": [
        "clang-diagnostic-implicit-function-declaration"
    ]

Not sure what the ideal fix would be or if this case matters enough to worry about.

We could possibly add all the clang-diagnostic-* values to the enums: https://releases.llvm.org/14.0.0/tools/clang/docs/DiagnosticsReference.html

[Burt-Silverman]

I found warning messages confusing, and not seeing the clang-diagnostic-* values confusing. Because everything has to be self-documenting as we come on board. So, it does matter.