microsoft
feat: Deleted documents are highlighted
Fixes #2437
- Deleted documents highlighted by line-through decoration
- No actions with deleted rows
It’s an interesting approach! However, I anticipate that once it’s available, there will be feature requests for an ‘undo’ operation.
Well, then we will say that result is just Query Representation what we can't change as well as undo any actions.
Why can't we remove these records from the table? Because the have statistics and metrics which linked to certain results in the table. My opinion, it is obvious that any actions with records will be represented only after re-running query.
Well, then we will say that result is just Query Representation what we can't change as well as undo any actions.
Why can't we remove these records from the table? Because the have statistics and metrics which linked to certain results in the table. My opinion, it is obvious that any actions with records will be represented only after re-running query.
I'd leave it for you, @bk201-, and @sevoku to decide, as it's in your domain. I wouldn't prefer to go down that UX path. If the correlation between the result set and the stats is a concern, I suggest replacing the metrics with a message stating that it's not available as the result set has changed.
I suggest replacing the metrics with a message stating that it's not available as the result set has changed.
@sevoku @tnaum-ms In this case any deletion will fail all metrics at all, not only for this page for every page. I'm not competent at this question, I would ask someone who uses both tabs. Questions like
- How often the metrics are required?
- How is important these data?
I don't have a strong opinion on this, I'd say let's go with this approach and see what feedback we get? We could also use a grey-ish text or background color.
@tnaum-ms don't we have support for deletion in Mongo? How do you handle it? We should shoot for the same experience, especially in such cases.
I simply remove it from the database and from the view. It's gone once a user confirms they want to delete. Deleted data being visible suggests an undo option that we don't and likely won't have.
seems we kinda forgot about this :)
@bk201- wrt metrics I'd suggest we show a warning inside the stats tab like "Dataset has changed, please rerun the query to update the metrics". Also we should check and see what happens with the continuation token? If we simply rerun the request would it update properly or do we really need to rerun the whole query? @tnaum-ms I'm not too much concerned about deleted items being visible. As long as they're visible (no query rerun) we can show a tooltip saying "Item deleted permanently" and if customers really ask for a recover feature, it won't be too hard, we could reconstruct the document from the row and create a new unsaved recovery document users could verify and re-upload.
