vscode-cmake-tools
vscode-cmake-tools copied to clipboard
buildKitVendor etc.. expansion for clang-cl support
This changes user-visible behavior
The following changes are proposed:
- Added
"ClangCl"to theCompilerVendorEnumtype - Enhanced vendor detection to identify
Clang-clkits by name - Updated version detection to treat
ClangClthe same asClang(reusing the same regex) - Fixed variable expansion for
${buildKitVendor},${buildKitVersionMajor}, etc., when using clang-cl-based kits on Windows
The purpose of this change
When using a clang-cl toolchain on Windows, variables like ${buildKitVendor} and ${buildKitVersionMajor} did not expand correctly in user-defined build directory paths. For example, with Cmake: Build Directory set to
${workspaceFolder}/build-${buildKitHostOs}-${buildKitVendor}${buildKitVersionMajor}-${buildKitTargetArch}-${buildType}
Before:
[cmake] -- Build files have been written to: C:/svn/myApp/build-win32-__unknown_vendor__0-unknown-Debug
After this change:
[cmake] -- Build files have been written to: C:/svn/myApp/build-win32-ClangCl20-x64-Debug
Could you add a changelog update? In a new 1.22 section. Thanks!
@microsoft-github-policy-service agree
@wchou158 rebase and squash into a single commit