vscode-cmake-tools icon indicating copy to clipboard operation
vscode-cmake-tools copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Configure precondition handler to return boolean to signal a successful recovery case

Open andreeis opened this issue 1 year ago • 2 comments

Fix for bug https://github.com/microsoft/vscode-cmake-tools/issues/3554. Making configure precondition handler return a boolean helps to differentiate the successful recovery cases so that, for example, when we manage to recover, to continue to build instead of stopping the workflow and have the user go through the build command again.

andreeis avatar May 20 '24 00:05 andreeis

Latest commit was done into this branch by mistake, it was meant for another bug.

andreeis avatar May 21 '24 02:05 andreeis

@andreeis This PR looks good, but do we need a CHANGELOG.md update?

gcampbell-msft avatar May 28 '24 19:05 gcampbell-msft

Just changelog update, no need to rebuild.

gcampbell-msft avatar Jul 26 '24 16:07 gcampbell-msft

Already approved, merging (after tests)

gcampbell-msft avatar Jul 29 '24 18:07 gcampbell-msft