vscode-cmake-tools icon indicating copy to clipboard operation
vscode-cmake-tools copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Add option to disable kit scan by default

Open qarni opened this issue 1 year ago • 2 comments

This change addresses #1461

This change adds an option to disable kit scan by default.

The following changes are proposed:

  • Sets kit to Unspecified if enable kit scan is set to false, cmake presets is not being used, and no kit was already selected while enable kit scan was set to true.

qarni avatar Feb 13 '24 17:02 qarni

[heart] Ion Todirel reacted to your message:

From: Fatima Qarni @.> Sent: Tuesday, February 13, 2024 5:42:08 PM To: microsoft/vscode-cmake-tools @.> Cc: Subscribed @.***> Subject: [microsoft/vscode-cmake-tools] Add option to disable kit scan by default (PR #3585)

This change resolves #[[1461]] This change adds an option to disable kit scan by default.

The following changes are proposed:

  • Sets kit to Unspecified if enable kit scan is set to false, and no kit was already selected while enable kit scan was set to true.

You can view, comment on, or merge this pull request online at:

https://github.com/microsoft/vscode-cmake-tools/pull/3585

Commit Summary

File Changes

(5 fileshttps://github.com/microsoft/vscode-cmake-tools/pull/3585/files)

Patch Links:

  • https://github.com/microsoft/vscode-cmake-tools/pull/3585.patch
  • https://github.com/microsoft/vscode-cmake-tools/pull/3585.diff

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode-cmake-tools/pull/3585, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADUIVMBOWRPCLBCPJUKW22TYTOQXBAVCNFSM6AAAAABDG5RUNWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZTEOBUGU3DOMI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

itodirel avatar Feb 13 '24 18:02 itodirel

@qarni Oh, one other thing, when we add new features, we make sure to make a CHANGELOG.md update, could you do that too?

gcampbell-msft avatar Feb 14 '24 14:02 gcampbell-msft

When was the PR released？

frankie-zeng avatar May 28 '24 09:05 frankie-zeng

@frankie-zeng It has not been released yet, but it will be very soon. Thank you for pinging on this issue!

gcampbell-msft avatar May 28 '24 10:05 gcampbell-msft

@gcampbell-msft thanks, I realy need this feature!!, see it in 1.18

frankie-zeng avatar May 29 '24 01:05 frankie-zeng

@frankie-zeng It should be officially released now in the most recent official version. THanks!

gcampbell-msft avatar May 29 '24 12:05 gcampbell-msft