vscode-cmake-tools icon indicating copy to clipboard operation
vscode-cmake-tools copied to clipboard

environmentSetupScript exit code not checked

Open joelfrederico opened this issue 1 year ago • 1 comments

Brief Issue Summary

I had an environmentSetupScript that worked. It started failing when IT removed a feature from the machine I needed. But since VSCode doesn't check the script's exit code, I never had a chance to notice that it was failing.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

The result of the script is here: https://github.com/microsoft/vscode-cmake-tools/blob/424005921358095a7a262274e00951af05924707/src/kit.ts#L693

As far as I can tell, its exit code is never checked. If it was checked, and an error raised, I could have noticed that my script wasn't working properly.

joelfrederico avatar Feb 01 '24 23:02 joelfrederico

@joelfrederico Thanks for the call-out we should make a failure here more obvious. Adding it to the backlog.

gcampbell-msft avatar Feb 06 '24 16:02 gcampbell-msft