Build log always shows source directory even when using out of source builds

[an3l]

Brief Issue Summary

When build the project using out of source build directory (vscode-build ), log still shows source directory (10.11 below)

[main] Building folder: 10.11
[build] Starting build
[proc] Executing command: /usr/local/bin/cmake --build /home/anel/GitHub/mariadb/server/build/vscode-build --config Debug --target all --

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

From file cmakeProject.js can be seen that only current folderName is used (source directory). It should be binaryDir IMHO.

Suggested fix should be

log.info(localize('run.build', 'Building folder: {0}', this.binaryDir ? this.binaryDir : this.folderName ), (targets && targets.length > 0) ? targets.join(', ') : '');

[gcampbell-msft]

Thanks for the heads up! I'll mark this as a bug and tag it. We welcome OSS contribution and would greatly appreciate you contributing this fix!

[gcampbell-msft]

Closed, fixed in #3778

[an3l]

@gcampbell-msft I forgot about this to contribute, glad to see it is fixed. Thanks