vscode-azureresourcegroups icon indicating copy to clipboard operation
vscode-azureresourcegroups copied to clipboard

Web Extension Migration

Open nturinski opened this issue 2 years ago • 6 comments

Resource Groups

  • [x] Configure webpack for each extension https://github.com/microsoft/vscode-azuretools/issues/1353
  • [x] Migrate remaining track 1 packages to track 2
    • [x] Identify the Azure SDK packages that need to be migrated to track 2.
  • [x] Polyfill or substitute any non-polymorphic dependencies and sub-dependencies
  • [x] Migrate from Azure Account extension authentication to VS Code auth provider
    • [x] Port over old implementation of VS Code auth provider https://github.com/microsoft/vscode-azureresourcegroups/pull/528
    • [x] Refactor Resources to use VS Code auth provider on UIKind.Web only https://github.com/microsoft/vscode-azureresourcegroups/pull/542
  • [x] Configure a delivery DevOps pipeline for web extensions
    • [x] Create a pipeline that can deliver vsix to a public storage blob
  • [x] Discern which features are incompatible in the vscode.dev environment https://github.com/microsoft/vscode-azureresourcegroups/issues/543
    • [ ] Refactor extension code into browser, Node.js, and common parts
  • [ ] Decrease size of extensions vsixes

Reference for migration path: https://code.visualstudio.com/api/extension-guides/web-extensions

nturinski avatar Jan 11 '23 01:01 nturinski

Potentially useful, the Dev CLI extension has some pipeline config that will create, publish, and comment with a link to the VSIX on PRs. Like so: https://github.com/Azure/azure-dev/pull/853#issuecomment-1375937535

bwateratmsft avatar Jan 11 '23 15:01 bwateratmsft

Potentially useful, the Dev CLI extension has some pipeline config that will create, publish, and comment with a link to the VSIX on PRs. Like so: Azure/azure-dev#853 (comment)

That's really nice.

If we also migrated our pipelines to GitHub Actions, we'd wouldn't have to leave GitHub to DevOps as often. See Python extension for example https://github.com/microsoft/vscode-python/actions/runs/3894486696

It has the artifacts at the bottom: image

alexweininger avatar Jan 11 '23 16:01 alexweininger

Potentially useful, the Dev CLI extension has some pipeline config that will create, publish, and comment with a link to the VSIX on PRs. Like so: Azure/azure-dev#853 (comment)

That's really nice.

If we also migrated our pipelines to GitHub Actions, we'd wouldn't have to leave GitHub to DevOps as often. See Python extension for example https://github.com/microsoft/vscode-python/actions/runs/3894486696

It has the artifacts at the bottom: image

It still comes in as a .zip file though. I wonder if that's something that's configurable.

nturinski avatar Jan 11 '23 17:01 nturinski

Rough Schedule for the above:

  • Configure webpack for each extension: 2 weeks
  • Migrate remaining track 1 packages to track 2: 2 weeks
  • Polyfill or substitute any non-polymorphic dependencies and sub-dependencies: TBD (Highly variable)
  • Migrate from Azure Account extension authentication to VS Code auth provider - 4 weeks
  • Configure a delivery DevOps pipeline for web extensions - 3 weeks
  • Discern which features are incompatible in the vscode.dev environment - 3 weeks (with workaround)
  • Decrease size of extensions vsixes - 3 weeks
PM/Eng Work Weeks Date
Nathan Configure webpack for each extension 1 weeks ~ 1/27
Nathan Migrate remaining track 1 packages to track 2: 2 weeks ~2/17
Megan & Matthew Polyfill or substitute any non-polymorphic dependencies and sub-dependencies 2 weeks  ~2/17
Meera Discern which features for Resource Groups is a MUST have by looking at data, verbatims and usage patterns 2 weeks ~2/3
Nathan Discern which features are incompatible in the vscode.dev environment 2 weeks ~2/3
Megan & Matthew Migrate from Azure Account extension authentication to VS Code auth provider 2 weeks ~2/17
Nathan Configure a delivery DevOps pipeline for web extensions 3weeks TBD
Nathan Decrease size of extensions vsixes 4 weeks TBD

@nturinski please take a look and change whatever I got wrong!

meeraharidasa avatar Jan 20 '23 17:01 meeraharidasa

One thing we need to do; a request to the VSCode team to permit customizing the cloud used for MS auth. i.e. custom clouds and such.

An issue exists already: https://github.com/microsoft/vscode/issues/162539

bwateratmsft avatar Jan 20 '23 18:01 bwateratmsft

Basically all of this work will be closed by: https://github.com/microsoft/vscode-azureresourcegroups/pull/611

nturinski avatar Mar 22 '23 21:03 nturinski

Looks like this extension still declares a dependency on "Azure Account" extension, which is deprecated.

Image

ggirard07 avatar Feb 05 '25 15:02 ggirard07

@ggirard07 It's the other way around--Azure Account depends on this extension.

bwateratmsft avatar Feb 05 '25 15:02 bwateratmsft

dam it, sorry for bothering :sweat:

ggirard07 avatar Feb 05 '25 19:02 ggirard07