vscode-azurelogicapps
vscode-azurelogicapps copied to clipboard
Fix #133 - Azure Environment Selector (Resubmitted)
Fix #133 - Azure Environment Selector (Resubmitted)
Resubmitting PR (previous PR #150 closed while I sorted things out).
I was able to update vscode-azureextensionui
to v0.17.1 which is the version the fix for Azure Government was introduced. I coupled the update with my previous changes where the baseUri
parameter is passed into LogicAppsManagementClient()
and got to a 95% working solution.
I have tested changes on both Azure Commercial and Azure Government. The following are the results.
- FIXED: Create Logic App command working for Azure Government
- FIXED: Promote command working for Azure Government
- FIXED: Enable, Disable commands working for Azure Government
- FIXED: Delete command working for Azure Government
- FIXED: Create Integration Account working for Azure Government
- FIXED: Create Integration Account SubChildren (ie: Partners) for Azure Government
- NEEDS TEST: Add Build Definition to Project
- NEEDS TEST: Open in Monitoring View
-
ERROR: openInDesigner throws subscriptionId error. Using
ms-rest.ServiceClientCredentials.signRequest()
instead of theLogicAppsManagementClient
.
@creativekinetix , just a heads up - I am busy doing some time-sensitive work (for BUILD) so it might take me some time to get back to this review. I will try to get back to this as soon as I can.
@joechung-msft, I appreciate the update. Let me know if there is anything I can do to help.