vscode-azureappservice
vscode-azureappservice copied to clipboard
microsoft
Display an empty "node_modules" directory after deploying successfully
OS: Win10 Build Version: 20191121.1 Regression: Not a Regression
Repro Steps:
- Get a sample project https://github.com/Azure-Samples/nodejs-docs-hello-world/archive/master.zip
- Add request package by "npm install request --save" to this sample project --> Open this project in VS Code.
- Create a Linux web app with Node.js LTS runtime --> Set the deployment source to "Node".
- Deploy the sample project to the new created web app --> Pop up a prompting dialog --> Select "Yes".
- Deploy.
- Succeed to deploy.
- Check the node_ folder.
Expect: All files display well under "node_modules".
Actual:
The "node_modules" directory is empty.
More Info:
- The website displays well.
- This issue also reproduces for Linux web app with Node.js 10.16 and Node.js 12.9(We only verified this issue with these 3 runtimes).
If you do a zip deploy without the .deployment file, it seems to work fine. Is Oryx no longer running npm install? @fiveisprime
I'm worried that this is a timing issue. Notice that they have no .deployment in the file list? Seems like the deployment is happening before the user confirms to enable build.
I'm seeing inconsistent behavior on this right now. Sometimes I get the prompt and other times I don't.
Based on the offline discussion, this seems to be caused because the wwwroot directory actually contains a symlink to the node_modules rather than having the node_modules being built in the wwwroot directory.
