vidur icon indicating copy to clipboard operation
vidur copied to clipboard

[Bugfix] Fix 1-indexing for replica_id in MetricsStore

Open sicario001 opened this issue 1 year ago • 4 comments

Issue MetricsStore uses 1-indexing for replica_id at several places even though replica_ids are 0-indexed.

Fix Update 1-indexed usage of replica_id in _replica_memory_usage, _replica_busy_time and _replica_mfu inside MetricsStore to 0-indexed.

sicario001 avatar Aug 28 '24 05:08 sicario001

@nitinkedia7 can you please take a look, thanks!

AgrawalAmey avatar Sep 06 '24 04:09 AgrawalAmey

@sicario001 Please look at the comments I have left and also accept the Contributor License Agreement (without which the PR cannot be merged).

nitinkedia7 avatar Sep 06 '24 08:09 nitinkedia7

@microsoft-github-policy-service agree

sicario001 avatar Sep 06 '24 17:09 sicario001

@sicario001 @nitinkedia7 are we good to merge?

AgrawalAmey avatar Sep 16 '24 18:09 AgrawalAmey