[curl] Use sources from GitHub Releases to fix `LIBCURL_VERSION` and `LIBCURL_TIMESTAMP`

[osipxd]

Is your feature request related to a problem? Please describe.

Currently when vcpkg checks out sources from GitHub, LIBCURL_VERSION has suffix "-DEV" and LIBCURL_TIMESTAMP is "[undefined]" Sources archives provided in GitHub Releases are produced using maketgz script which sets correct version and timestamp.

Proposed solution

Use sources from GitHub Releases instead of checking out a git repository.

Describe alternatives you've considered

No response

Additional context

For example, Conan uses sources from releases to build curl.

[osipxd]

I could try to contribute a fix if you approve the solution

[dg0yt]

We can change the display strings, but I'm not convinced of switching away from vcpkg_from_github.

[osipxd]

We can change the display strings

Do you mean run some parts of the maketgz script? I suppose LIBCURL_TIMESTAMP will be equal to the date when the binary has been built then, not the curl release date?

I'm not convinced of switching away from vcpkg_from_github.

Are there any downsides of switching from it?

[dg0yt]

Do you mean run some parts of the maketgz script? I suppose LIBCURL_TIMESTAMP will be equal to the date when the binary has been built then, not the curl release date?

I mean to outright remove the -DEV fragment and to set LIBCURL_TIMESTAMP string to either [vcpkg] or something more specific for that version. I acknowledge that this is not the releases timestamp, but it isn't pristine source or official binaries either.

Are there any downsides of switching from it?

Nothing dramatic.

• Ignoring the dominant pattern.
• Decoupling from pristine git sources. (git sources isolated the liblzma port from tarball manipulations.)
• Disabling the availability of --head builds.
• Making it a little bit more difficult to prepare port updates ahead of releases. (such as #48563).

OTOH I don't consider the gain from switching dramatic.

[osipxd]

I don't consider the gain from switching dramatic.

I agree that it doesn't worth it

[dg0yt]

I will try to apply my suggested modifications to the next release. This issue might help as a reminder.