vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

[qt5-base & qtbase] Fix error on arm64-windows

Open pedrolcl opened this issue 1 year ago • 11 comments

Patch by Oliver Wolff: https://github.com/qt/qtbase/commit/b66ecb295ecc3981b1c21f01d62c9066f5d6e6ca

qmake has been fixed in 6.8, but all other versions need to be patched for arm64.

The original report is about qt5-base: Build error on arm64-windows. but this PR also adds the same patch to Qt6.

Fixes #37210

pedrolcl avatar Oct 12 '24 20:10 pedrolcl

you need to bump (add a 1 to the number there or create it with value 1 if missing) "port-version" for both qt5-base/vcpkg.json and qtbase/vcpkg.json

cenit avatar Oct 13 '24 20:10 cenit

and vcpkg team should move to test arm64_windows on real arm64_windows ;)

cenit avatar Oct 13 '24 20:10 cenit

you need to bump (add a 1 to the number there or create it with value 1 if missing) "port-version" for both qt5-base/vcpkg.json and qtbase/vcpkg.json

  1. The above modifications
  2. Please commit after modification
  3. Run ./vcpkg x-add-version testPort to generate a series of version according to your commit info (Add --overwrite-version when generating other than the first time)
    vcpkg/versions/
        t-/
            testport.josn (automatically generated)
        baseline.json (automatically add records)
    
  4. Commit verison information again
  5. Push together

maintainer-guide.md#versioning

MonicaLiu0311 avatar Oct 14 '24 02:10 MonicaLiu0311

and vcpkg team should move to test arm64_windows on real arm64_windows ;)

Hi! Thanks everyone for the feedback. What do you mean, that the CI build of 'arm64_windows` is not performed on real ARM64 hardware, or in Windows OS?

I did build Qt5 locally on my new Surface Pro 11, with Snapdragon® X Elite and Windows 11. I want to use this device to port and test my software to windows+arm64. That is why I've opened this PR.

The build time on the CI server ( qt5-base:x64-windows: SUCCEEDED: 8 min) is good enough for me, and matches the build time I got on the Surface.

pedrolcl avatar Oct 14 '24 19:10 pedrolcl

and vcpkg team should move to test arm64_windows on real arm64_windows ;)

Hi! Thanks everyone for the feedback. What do you mean, that the CI build of 'arm64_windows` is not performed on real ARM64 hardware, or in Windows OS?

vcpkg CI does arm64-windows as a cross build on x64-windows. So there is no native testing on arm64 windows hosts.

(And some ports are hard to adapt to vcpkg's cross-build pattern. qt5-base is such a port.)

dg0yt avatar Oct 14 '24 19:10 dg0yt

Can somebody tell me why the arm64_osx build has failed? or is there a build log that I can access?

pedrolcl avatar Oct 14 '24 20:10 pedrolcl

Can somebody tell me why the arm64_osx build has failed? or is there a build log that I can access?

in the azure pipeline you can find everything. Here the artifacts with the published logs https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/108037/artifacts?artifactName=failure%20logs%20for%20arm64-osx&api-version=7.1&%24format=zip

cenit avatar Oct 14 '24 20:10 cenit

Can somebody tell me why the arm64_osx build has failed? or is there a build log that I can access?

in the azure pipeline you can find everything. Here the artifacts with the published logs https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/108037/artifacts?artifactName=failure%20logs%20for%20arm64-osx&api-version=7.1&%24format=zip

Thanks. I see that there is a missing header that couldn't be installed. It does not explain why yesterday the same build succeeded.

pedrolcl avatar Oct 14 '24 21:10 pedrolcl

/azp run

BillyONeal avatar Oct 15 '24 19:10 BillyONeal

Rerunning due to network mistake last night.

BillyONeal avatar Oct 15 '24 19:10 BillyONeal

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 15 '24 19:10 azure-pipelines[bot]