microsoft
[pcl] When cross-compiling pcl for Android pre-set some cache variables.
Fixes #41505.
- [x] Changes comply with the maintainer guide.
- [ ] SHA512s are updated for each updated download.
- [ ] The "supports" clause reflects platforms that may be fixed by this new version.
- [ ] Any fixed CI baseline entries are removed from that file.
- [ ] Any patches that are no longer applied are deleted from the port's directory.
- [ ] The version database is fixed by rerunning
./vcpkg x-add-version --alland committing the result. - [ ] Only one version is added to each modified port's versions file.
@jackjansen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"Contributor License Agreement
@microsoft-github-policy-service agree
Sorry for the delay in answering this.
The problem this fix solves is that these build-time tests depend on running a program to test the existence of some aligned-allocation functions. This cannot work when cross-compiling.
When building for Android you're always cross-compiling. Moreover, these macros aren't actually needed because they're used in one place in the pcl sources, and in that place there's a separate #if for Android.
I've reported the same issue in the pcl repo, but past experience suggests that the pcl developers move at glacial speed.