vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

[gtsam] Update to 4.2.0 and add new feature for native arch build

Open andre-nguyen opened this issue 1 year ago • 4 comments

Add a port feature which provides access to the cmake option GTSAM_BUILD_WITH_MARCH_NATIVE which in turn controls building with -march=native. This is important when the consuming application has native instructions enabled.

  • [x] Changes comply with the maintainer guide.
  • [x] SHA512s are updated for each updated download.
  • [ ] ~The "supports" clause reflects platforms that may be fixed by this new version.~
  • [ ] ~Any fixed CI baseline entries are removed from that file.~
  • [ ] ~Any patches that are no longer applied are deleted from the port's directory.~
  • [x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • [x] Only one version is added to each modified port's versions file.

andre-nguyen avatar Aug 26 '24 16:08 andre-nguyen

you can try to update the port to 4.2.0

talregev avatar Aug 26 '24 16:08 talregev

I would recommend adding

set(VCPKG_C_FLAGS -march=native) 
set(VCPKG_CXX_FLAGS -march=native) 

to your triplet file to enable the flag globally instead of exposing this as a recipe feature.

valgur avatar Aug 26 '24 17:08 valgur

I would recommend adding

set(VCPKG_C_FLAGS -march=native) 
set(VCPKG_CXX_FLAGS -march=native) 

to your triplet file to enable the flag globally instead of exposing this as a recipe feature.

In my opinion it should stay as a feature like he already dose.

talregev avatar Aug 27 '24 15:08 talregev

@valgur I will leave the option there since it is an available option on the gtsam side. I will also use your suggestion of editing my triplet file.

andre-nguyen avatar Aug 27 '24 15:08 andre-nguyen

@andre-nguyen Change to not draft to notify you are ready for review.

talregev avatar Aug 28 '24 14:08 talregev