vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

[openssl] install cmake config wrapper only at the end

Open cenit opened this issue 2 months ago • 6 comments

Fixes #37987

  • [x] Changes comply with the maintainer guide.
  • [x] SHA512s are updated for each updated download.
  • [x] The "supports" clause reflects platforms that may be fixed by this new version.
  • [x] Any fixed CI baseline entries are removed from that file.
  • [x] Any patches that are no longer applied are deleted from the port's directory.
  • [x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • [x] Only one version is added to each modified port's versions file.

i don't know why adding the config wrapper at the beginning results in a missing file in the end, but at least in this way it works.

Could it be that including a portfile in a portfile triggers any cleanup in the packages folder?

cenit avatar Apr 24 '24 11:04 cenit

Note: I will be converting your PR to draft status. Please click "Ready for review" after making the fix and modifications.

WangWeiLin-MV avatar Apr 28 '24 07:04 WangWeiLin-MV

@WangWeiLin-MV: converting this to draft makes no sense.

Neumann-A avatar Apr 28 '24 09:04 Neumann-A

which reviews?

cenit avatar Apr 29 '24 10:04 cenit

i don't think any regression is due to this pr nor i have time to make those fixes!

cenit avatar Apr 29 '24 10:04 cenit

@BillyONeal it's more than one month that many ports (anything that depends on openssl) cannot be built on linux on many machines (e.g. any github action runner)

this pr fixes the symptom (but does not understand the real problem)

what shall we do to better expedite the merge of a fix?

cenit avatar Apr 30 '24 04:04 cenit

@cenit Please do a git commit --allow-empty -m CI; git push to trigger CI.

dg0yt avatar Apr 30 '24 04:04 dg0yt

kddockwidgets regression described here https://github.com/microsoft/vcpkg/issues/38509 and independent from this PR

cenit avatar May 02 '24 05:05 cenit

sorry can i ask what is blocking the merge of this PR? there are no regressions anymore after the last retrigger

cenit avatar May 11 '24 16:05 cenit