vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

[vcpkg-tool-swig] Add new tool port

Open cbentejac opened this issue 1 year ago • 5 comments

  • [x] Changes comply with the maintainer guide.
  • [x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • [x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • [x] The versioning scheme in vcpkg.json matches what upstream says.
  • [x] The license declaration in vcpkg.json matches what upstream says.
  • [x] The installed as the "copyright" file matches what upstream says.
  • [x] The source code of the component installed comes from an authoritative source.
  • [x] The generated "usage text" is accurate. See adding-usage for context.
  • [x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • [x] Only one version is in the new port's versions file.
  • [x] Only one version is added to each modified port's versions file.

cbentejac avatar Feb 06 '24 15:02 cbentejac

@microsoft-github-policy-service agree

cbentejac avatar Feb 07 '24 09:02 cbentejac

@cbentejac, Thanks for your PR, looks the PR build failed in many triplets, this is error log, please take a look:

CMake Error at ports/swig/portfile.cmake:26 (file):
  file COPY cannot find "/mnt/vcpkg-ci/p/swig_x64-linux/bin/Lib": No such
  file or directory.
Call Stack (most recent call first):
  scripts/ports.cmake:170 (include)

JonLiu1993 avatar Feb 27 '24 08:02 JonLiu1993

It's a tool, should this be a release only build?

F.t.r. there's an alternative (similar): ports/swig/portfile.cmake

m-kuhn avatar Mar 20 '24 06:03 m-kuhn

Ping @cbentejac for response.

JonLiu1993 avatar Oct 11 '24 07:10 JonLiu1993

Thanks @dg0yt for your feedback. I renamed the port and applied your suggested changes. I haven't added a test project yet, though.

cbentejac avatar Oct 11 '24 17:10 cbentejac

Pinging @cbentejac Can you address the review suggestions? Thanks!

JonLiu1993 avatar Nov 15 '24 07:11 JonLiu1993

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

JonLiu1993 avatar Nov 15 '24 07:11 JonLiu1993

@cbentejac do you have plans to continue working on this in the near future?

m-kuhn avatar Dec 19 '24 07:12 m-kuhn

Hi @m-kuhn,

Yes, I'm planning on finishing this port but haven't been able to find the time to wrap it up lately.

cbentejac avatar Dec 27 '24 10:12 cbentejac