vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

[simdutf,scnlib] update to 4.0.9,2.0.0

Open jiayuehua opened this issue 1 year ago • 3 comments

  • [X] Changes comply with the maintainer guide
  • [X] SHA512s are updated for each updated download
  • [ ] ~The "supports" clause reflects platforms that may be fixed by this new version~
  • [ ] ~Any fixed CI baseline entries are removed from that file.~
  • [ ] ~Any patches that are no longer applied are deleted from the port's directory.~
  • [X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • [X] Only one version is added to each modified port's versions file.

jiayuehua avatar Jan 29 '24 22:01 jiayuehua

What do these patches do? Can you submit them upstream?

data-queue avatar Jan 30 '24 21:01 data-queue

https://github.com/eliaskosunen/scnlib/pull/99 https://github.com/eliaskosunen/scnlib/pull/98 I have open two PR on upstream repo. one patch is fix SCN_HAS_STD_REGEX_MULTILINE , only gcc 11.4 or above and clang 15.0.0 or above add support for std::regex_constants::multiline. The other is fix build error :

/mnt/vcpkg-ci/b/scnlib/src/v2.0.0-cc5e6bd45f.clean/src/scn/impl/reader/float_reader.cpp:275:22: error: no member named 'wcstod_l' in the global namespace; did you mean 'wcstold_l'?
            return ::wcstod_l(str, str_end, cloc);

and from /android-ndk-r25c/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/wchar.h we can see those functions are only supported on ANDROID_API >= 28

131 │ #if ANDROID_API >= 28 132 │ double wcstod_l(const wchar_t* __s, wchar_t** __end_ptr, locale_t __l) __INTRODUCED_IN(28); 133 │ #endif /* ANDROID_API >= 28 */

141 │ #if ANDROID_API >= 28 142 │ float wcstof_l(const wchar_t* __s, wchar_t** __end_ptr, locale_t __l) __INTRODUCED_IN(28); 143 │ #endif /* ANDROID_API >= 28 */

jiayuehua avatar Jan 31 '24 01:01 jiayuehua

Patches for scnlib merged upstream.

eliaskosunen avatar Feb 12 '24 20:02 eliaskosunen

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

FrankXie05 avatar Feb 22 '24 06:02 FrankXie05

@FrankXie05 Please review this PR again.

jiayuehua avatar Mar 05 '24 02:03 jiayuehua