vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

[vcpkg] Let it fails when uploading binary caching failed

Open xiaozhuai opened this issue 3 years ago • 15 comments

error: curl failed to put file to https://xxx.com/packages/x64-osx-dynamic/zlib/1.2.13/23bb6610a3e542385afd48ad46945d93065459e7a691911c8ee88183779fc221.zip with exit code 6 and http code 0.

I config a http binary caching backend for my vcpkg, and is the only one, which is read-write.

I'd like to let it fails when uploading failed.

xiaozhuai avatar Jan 13 '23 10:01 xiaozhuai

Maybe we should add a flag like --require-binary-cache-upload or --binarycache-hard-errors

autoantwort avatar Jan 13 '23 16:01 autoantwort

If you get an error like error: curl failed to execute with exit code 6. while uploading to the binary cache you already get a full stop, which is inconsistent.

autoantwort avatar Jan 13 '23 16:01 autoantwort

Maybe we should add a flag like --require-binary-cache-upload or --binarycache-hard-errors

Maybe we should also add an env variable to control this. Then we can make it as the default behavior through env.

xiaozhuai avatar Jan 20 '23 02:01 xiaozhuai

If you get an error like error: curl failed to execute with exit code 6. while uploading to the binary cache you already get a full stop, which is inconsistent.

Btw if anyone else gets this error randomly: I got rate limited by my pihole... Increasing the rate limit for DNS requests solved this problem.

autoantwort avatar Mar 28 '23 01:03 autoantwort

Maybe we need to retry a few more times if uploading failed.

xiaozhuai avatar Mar 28 '23 03:03 xiaozhuai

Time flies, any plan on this issue?

xiaozhuai avatar Jul 07 '23 04:07 xiaozhuai

@xiaozhuai hey! I've been using vcpkg extensively for a project of mine and would like to take this up to give back to the community. Can I work on this?

ameya-deshmukh avatar Jul 23 '23 10:07 ameya-deshmukh

@ameya-deshmukh Of course, you can fork vcpkg-tool and open a PR. : )

xiaozhuai avatar Jul 24 '23 02:07 xiaozhuai

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

github-actions[bot] avatar Jan 21 '24 01:01 github-actions[bot]

still a thing

autoantwort avatar Jan 21 '24 10:01 autoantwort

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

github-actions[bot] avatar Jul 21 '24 01:07 github-actions[bot]

still a thing

autoantwort avatar Jul 21 '24 08:07 autoantwort

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

github-actions[bot] avatar Jan 25 '25 01:01 github-actions[bot]

.

autoantwort avatar Jan 25 '25 02:01 autoantwort

I'd like this feature too. I run ci builds that should upload packages for others to use, it if doesn't manage to upload the package it has built it should report failure. Now I need to verify that the upload did work, which means parsing logs, and is error prone in itself.

prvg-sso avatar Jun 13 '25 08:06 prvg-sso