vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

[angle] update list of required apt packages

Open wrobelda opened this issue 3 years ago • 6 comments

Describe the pull request libmesa-dev is not the package that needs to be installed, mesa-common-dev is.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No change.

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes. This is a cosmetic change to the pre-compilation message, so I did not bump the port-version as there's no need to trigger a recompilation of this and all dependant ports.

wrobelda avatar Sep 15 '22 17:09 wrobelda

@wrobelda Please upgrade the port version in angle\vcpkg.json.

Adela0814 avatar Sep 16 '22 06:09 Adela0814

@wrobelda Please upgrade the port version in angle\vcpkg.json.

I explicitly addressed that in the PR description. Is bumping port version really necessary in this case?

wrobelda avatar Sep 16 '22 08:09 wrobelda

I explicitly addressed that in the PR description. Is bumping port version really necessary in this case?

Yes, you need upgrade the port version once the portfile.cmake is changed.

Adela0814 avatar Sep 16 '22 09:09 Adela0814

So strictly speaking this should actually depend on the mesa and the x* ports

Neumann-A avatar Sep 16 '22 09:09 Neumann-A

So strictly speaking this should actually depend on the mesa and the x* ports

I had a strong deja vu we talked about this already, and after checking it turns out I have a local branch that prepared for this in may 2021, which I forgot about 😂 EDIT: indeed, #16272

Let's push this change first and I'll try get the other PR done independently.

wrobelda avatar Sep 16 '22 09:09 wrobelda

Yes, you need upgrade the port version once the portfile.cmake is changed.

It definitely is an overkill, but did as you suggest and updated the PR. Should be ready now.

wrobelda avatar Sep 16 '22 09:09 wrobelda

@Adela0814 as noted, this is ready.

wrobelda avatar Sep 27 '22 12:09 wrobelda