vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

[vcpkg scripts] Crosscompiling fixes

Open Neumann-A opened this issue 2 years ago • 7 comments

Neumann-A avatar Aug 31 '22 18:08 Neumann-A

@m-kuhn any other additions necessary?

Neumann-A avatar Sep 04 '22 21:09 Neumann-A

Sending it through the build pipeline now

m-kuhn avatar Sep 05 '22 15:09 m-kuhn

Looks good, minimal additional changes are needed for iOS, either in here or as a follow up

https://github.com/Neumann-A/vcpkg/pull/9

m-kuhn avatar Sep 06 '22 09:09 m-kuhn

@m-kuhn does the CMAKE_${lang}_OSX_DEPLOYMENT_TARGET_FLAG change work for you?

Neumann-A avatar Sep 07 '22 17:09 Neumann-A

@m-kuhn does the CMAKE_${lang}_OSX_DEPLOYMENT_TARGET_FLAG change work for you?

Yes, this looks good.

Sidenote: it took me an extra run to figure out that a change to scripts/get_cmake_vars/CMakeLists.txt does not trigger a rebuild, so I had to fake a modification into scripts/cmake/vcpkg_configure_make.cmake to force rebuild.

m-kuhn avatar Sep 08 '22 13:09 m-kuhn

@JackBoosY another baseline regression...

Neumann-A avatar Sep 15 '22 09:09 Neumann-A

@JackBoosY another baseline regression...

Fixing in https://github.com/microsoft/vcpkg/pull/26783.

JackBoosY avatar Sep 15 '22 09:09 JackBoosY

@Neumann-A Could you please resolve the conflicts?

LilyWangLL avatar Sep 26 '22 06:09 LilyWangLL

/azp run

vicroms avatar Oct 03 '22 04:10 vicroms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 03 '22 04:10 azure-pipelines[bot]

Hmm don't know what happened to jemalloc on osx. Has been green in https://github.com/microsoft/vcpkg/pull/26617/commits/184abe3c41315e6a353b0016eb8ebce38c372b92 and only thing I did was merge with master. Looks like a concurrency issue?

Neumann-A avatar Oct 04 '22 17:10 Neumann-A

Hmm don't know what happened to jemalloc on osx. Has been green in 184abe3 and only thing I did was merge with master. Looks like a concurrency issue?

install: mkdir /Users/vagrant/Data/packages/jemalloc_x64-osx/Users/vagrant/Data/installed: File exists

This is a typical symptom of concurrency issues during make install on osx. We need a DISABLE_PARALLEL_INSTALL and/or a reliable mkdir wrapper for osx.

dg0yt avatar Oct 04 '22 18:10 dg0yt

Should we wait for #27105 merge or just rerun the pipeline test?

JackBoosY avatar Oct 08 '22 02:10 JackBoosY