vcpkg
vcpkg copied to clipboard
[luajit] add 2.1.0-beta3
Fix #25851
Update luajit to the latest version 2.1.0-beta3
Note: no feature need to test
I will wait for the 2.1.0 stable version to be released and continue to upgrade to the latest version and then merge pr
Whouldn't it be possible to add the beta version and leave the baseline untouched? That way people could explicitly opt-in via versioning.
Whouldn't it be possible to add the beta version and leave the baseline untouched? That way people could explicitly opt-in via versioning.
If you want to use this beta, just use my pr, you can also ask upstream if they will release the latest version soon, because I found that they are still submitting pr upstream to solve the problem recently
Related upstream issues: https://github.com/LuaJIT/LuaJIT/issues/563
Thanks!
I think the 'luajit.lib' should also be installed.
This PR as merged doesn't actually build or install LuaJIT. The minilua
that it installs is a build-time tool used for code generation, the actual LuaJIT libraries are not successfully built nor installed.
The build bails out very early being provided an incorrect path to vm_*.dasc
.
If you fix that then the build of LuaJIT itself is broken in that the generated source files do not seem to generate like they do with unmodified upstream source and fails the build again due to this.
These problems are likely due to the separation of the build directory from source directory, causing the generators to not find all the source.
I've managed to build this properly now by undoing most of the changes in this PR. Should one open a new PR to fix the state of this port in vcpkg?
001-fix-build-path.patch
:
ALL_LIB
needs to include %SOURCEDIR%\lib_buffer.c
, the current patch accidentally removed that source file from the variable.
The command to generate host\buildvm_arch.h
needs to point out the correct path for both the generated header and %DASC%
. If it's unacceptable to generate data in the source tree, we'll instead need to create the target directory and augment include search paths to find it.
-minilua %DASM% -LN %DASMFLAGS% -o host\buildvm_arch.h %DASC%
+minilua %DASM% -LN %DASMFLAGS% -o %SOURCEDIR%\host\buildvm_arch.h %SOURCEDIR%\%DASC%
portfile.cmake
:
This file needs to revert all the changes around INSTALL
files, the proper files to install are as before luajit.exe
, lua51.lib
and lua51.dll
; in a correct build minilua
files are deleted as the build concludes.
I've managed to build this properly now by undoing most of the changes in this PR. Should one open a new PR to fix the state of this port in vcpkg?
Done, I think :) https://github.com/microsoft/vcpkg/pull/26360
Thanks for the report.