vcpkg
vcpkg copied to clipboard
microsoft
[bitar] Add new port for bitar
Describe the pull request
Add the support for bitar, a C++ library to simplify accessing hardware compression/decompression accelerators.
-
Which triplets are supported/not supported? Have you updated the CI baseline?
Support only on Linux. And yes I updated file
ci.baseline.txt, because bitar only supports compiling with GCC>=10. -
Does your PR follow the maintainer guide?
Yes -
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
I would suggest to mark your PR as draft if it is still work in progress.
I had a couple of unexpected errors from the CI that I didn't notice from my local development. Sorry for having multiple force pushes. But I think this PR has gotten to the point for reviewing. I will update the code according to your feedback. Thanks!
I'll rather wait to merge this PR until it has CI coverage, I'll talk with the team about updating our VMs,
I'll rather wait to merge this PR until it has CI coverage, I'll talk with the team about updating our VMs,
Alright. Please let me know how it goes.
We wanted to update the fleet to Ubuntu 22.04 last month but ran into a problem because there is no cudnn available yet for that release. Perhaps we need to turn off anyone who forces a dependency on cudnn instead....
Do you have a plan for when to update the VM?
No concrete plans right now. If there were cudnn available for 22.04 we would have done it already; as it stands we have to make a judgement call balancing being able to turn ports like this on against everything that uses cudnn being forced to turn off.
Is it possible to update the GCC in the VM without updating the OS version?
I see. I found that other ports like eve, coroutine, and mfl require GCC>=10 as well. So for this PR to be able to accept, do I have to enable and pass at least one of the CI checks?
I see. I found that other ports like eve, coroutine, and mfl require GCC>=10 as well. So for this PR to be able to accept, do I have to enable and pass at least one of the CI checks?
Our policy on accepting ports that we can't validate has changed with registries becoming a more or less stable feature that people can use as a workaround. Give us until at least this upcoming Patch Tuesday to see if we end up doing 22.04 anyway.
I found that other ports like eve, coroutine, and mfl require GCC>=10 as well
Note that these ports can be tested in CI on at least one other triplet than linux.
x64-linux failure:
In file included from /mnt/vcpkg-ci/buildtrees/bitar/src/v0.0.1-fe9e9758bc.clean/src/memory.cc:23:
/mnt/vcpkg-ci/buildtrees/bitar/src/v0.0.1-fe9e9758bc.clean/src/include/memory.h:34:10: fatal error: span: No such file or directory
34 | #include <span> // NOLINT
| ^~~~~~
compilation terminated.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
I just rebased the code and it causes the CI to also test other ports. Can I just test the bitar alone?
It looks like the port "libilbc" failed in the building. But I don't think I used it as one of the dependencies.
The CI still builds "libilbc". Do you know why it involves the building of this library?