[opensubdiv] Opensubdiv improvements

[theblackunknown]

Describe the pull request

What does your PR fix?

This PR:

• adds a opengl feature to opensubdiv to support OpenGL backend.
• improve some feature descriptions.
• install a CMake Config for OpenSubdiv (which is also something pending in upstream repo cf. PixarAnimationStudios/OpenSubdiv#1242) which solves microsoft/vcpkg#20932.

Supersed #24467 which is stuck due to a strange errors about CLA

Which triplets are supported/not supported? Have you updated the CI baseline?

all, No

Does your PR follow the maintainer guide?

Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[BillyONeal]

I want to give upstream an opportunity to review this before merging the patch.

[theblackunknown]

I want to give upstream an opportunity to review this before merging the patch.

Sounds good to me, I have tried to mirror all my port changes in upstream project too. Let's see how this goes.

[Adela0814]

Any progress?

[theblackunknown]

Any progress?

I have signed a CLA so that upstream repo can accept my changes and they filed those changes as an internal issue. I do not have more information to share, the best we can do is subscribe to the upstream PR and wait.

[Adela0814]

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

[theblackunknown]

@Adela0814 can we please reopen this PR ? (I do not think I have the rights to do myself) Patience has paid and the upstream projects finally gave us the positive answer we were looking for: PixarAnimationStudios/OpenSubdiv#1242

@BillyONeal I think this answer your question

If this is reopen, this PR can be greatly simplified by bumping it to the correct SHA and use upstream merged changes to produce the CMake config

[BillyONeal]

@Adela0814 can we please reopen this PR ? (I do not think I have the rights to do myself) Patience has paid and the upstream projects finally gave us the positive answer we were looking for: PixarAnimationStudios/OpenSubdiv#1242

@BillyONeal I think this answer your question

I agree. Can you change this to vcpkg_download_distfile https://github.com/PixarAnimationStudios/OpenSubdiv/commit/287cb80619ad784f38bd25227f4bfd8af5b71c30.patch ? That way it's obvious that when a version is updated including this commit it can be skipped.

Thanks!

[theblackunknown]

I tried it in commit unfortunately it does not apply the patch cleanly on top of the existing repo commit (done in commit c58374cf555c1d9c95eed4cc97e94a33bfa8e92d) cf. apply-patch-failure.txt

It the current commit does not allow to clean apply the patch, I would rather use this opportunity to bump opensubdiv port to v3.5.0 - which contains this commit - (done in 9ce4ee8167c064efba5cd425376534d8e054e750)

[theblackunknown]

I notice that this PR now either superseds - or has to be merged after - #26628

[Adela0814]

Please ping us if this PR is ready for review again.

[theblackunknown]

I formally ping you for review @Adela0814 :)

[BillyONeal]

Thanks for the update!