JSON file includes do not change lowest common ancestor for outDir

[Sainan]

Example project to reproduce the issue: repro.zip

Result when running tsgo here:

build\
  index.js

Expected result / what tsc outputs:

build\
  static\
    data.json
  src\
    index.js

[harish2704]

I also faced this same issue. I manually copied all json files using following command rsync -a --include="*/" --include="*.json" --exclude="*" src/ lib/

Other than this issue, typescript-go was able to complete a medium sized TS project very quickly.

[Sainan]

Possibly an issue with the porting of JSON includes (#565)

[jakebailey]

I think this just comes down to sourceFileMayBeEmitted having a TODO for adding JSON support.

[Sainan]

I don't see the TODO you speak of. 🤔

Edit: Oh, you might mean the one in emitter.go with the !!! comment.

[jakebailey]

Yes, the !!! comments are "this isn't ported yet" markers.

[jakebailey]

Can you try again in the next nightly? It's possible this was fixed in #1234.

[Sainan]

Compiled tsgo @ 652b18c4bd74ecd4bb9d18c44fbaf39d69aa4cc6; seems to still exibit the same broken behaviour. Repro is still valid.

[jakebailey]

Thanks for checking.