typescript-go icon indicating copy to clipboard operation
typescript-go copied to clipboard
Published 1 week ago • verified publisher icon microsoft

feature: Port emitter functions

Open KeoFoxy opened this issue 9 months ago • 2 comments

Ported:

  • IsEmitBlocked
  • getSourceMapFilePath
  • getDeclarationEmitOutputFilePath
  • getDeclarationEmitOutputFilePathWorker
  • ~~GetDeclarationEmitExtensionForPath~~

Added

  • SetEmitBlocked
  • BuildInfo struct for future usage

KeoFoxy avatar Mar 14 '25 10:03 KeoFoxy

I'm not entirely convinced it's a good idea to port these functions now, when they aren't be used or tested, and may not actually be useful for future code.

jakebailey avatar Mar 15 '25 20:03 jakebailey

They were marked as TODOs so I decided to port them. So should I keep only used ones? What about BuildInfo? Remove it as well?

KeoFoxy avatar Mar 15 '25 22:03 KeoFoxy

@weswigham If you're nearing the completion of some dts emit, are the functions in this PR useful to you, or are you going to just do something from scratch?

jakebailey avatar Apr 24 '25 19:04 jakebailey

Nah, only getDeclarationEmitOutputFilePath which I have a slightly different version of already. Nothing I'm working on needs any of the rest of these

weswigham avatar Apr 24 '25 20:04 weswigham

Yeah, I'm not sure we need this PR right now, then.

jakebailey avatar Apr 24 '25 20:04 jakebailey