typescript-go icon indicating copy to clipboard operation
typescript-go copied to clipboard

binder: Order of declarations is backward from source order in union type

Open sandersn opened this issue 10 months ago • 2 comments

discriminantPropertyCheck, discriminantsAndPrimitives

This is probably an intended or allowed difference that needs to be ignored by having both Strada and Corsa sort their symbol baseline declarations in source order.

sandersn avatar Feb 10 '25 17:02 sandersn

Is there a repro? I'm pretty certain this is intended given the new type ordering.

ahejlsberg avatar Feb 10 '25 19:02 ahejlsberg

The two compiler tests

  • discriminantPropertyCheck
  • discriminantsAndPrimitives

Probably one or both of Corsa and Strada need to be able to produce baselines in "compatibility mode" that does things like sorting baseline declarations (plus overlooking other diffs).

sandersn avatar Feb 13 '25 18:02 sandersn

This is now fixed, given we diff against tsc that's also been modified for the union ordering.

jakebailey avatar Jun 04 '25 07:06 jakebailey